Summary: | ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() in void JSC::sanitizeStackForVM(JSC::VM *) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, commit-queue, ews-watchlist, fpizlo, hi, joepeck, keith_miller, mark.lam, msaboff, saam, timothy, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=180492 | ||||||
Attachments: |
|
Description
Ryan Haddad
2017-12-05 12:56:21 PST
Looking at crashlogs from the bots, this assertion failure has also been seen attributed to: http/tests/inspector/network/ping-type.html webaudio/audiobuffersource-multi-channels.html webaudio/test-basic.html webaudio/up-mixing-stereo-51.html webaudio/audiobuffersource-playbackrate.html webaudio/oscillator-triangle.html webaudio/up-mixing-mono-stereo.html Hi Ryan, any idea when this failure started manifesting? Is it correlated to some recently landed patch? (In reply to Mark Lam from comment #3) > Hi Ryan, any idea when this failure started manifesting? Is it correlated > to some recently landed patch? Still looking, it appears to have been happening since late October. Seems like we just need to grab the API lock here. (In reply to Ryan Haddad from comment #2) > Looking at crashlogs from the bots, this assertion failure has also been > seen attributed to: > http/tests/inspector/network/ping-type.html > webaudio/audiobuffersource-multi-channels.html > webaudio/test-basic.html > webaudio/up-mixing-stereo-51.html > webaudio/audiobuffersource-playbackrate.html > webaudio/oscillator-triangle.html > webaudio/up-mixing-mono-stereo.html Can you post crashlogs for these. Created attachment 328556 [details]
patch
Comment on attachment 328556 [details]
patch
r=me
(In reply to Saam Barati from comment #6) > (In reply to Ryan Haddad from comment #2) > > Looking at crashlogs from the bots, this assertion failure has also been > > seen attributed to: > > http/tests/inspector/network/ping-type.html > > webaudio/audiobuffersource-multi-channels.html > > webaudio/test-basic.html > > webaudio/up-mixing-stereo-51.html > > webaudio/audiobuffersource-playbackrate.html > > webaudio/oscillator-triangle.html > > webaudio/up-mixing-mono-stereo.html > > Can you post crashlogs for these. https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r225482%20(1105)/http/tests/inspector/network/ping-type-crash-log.txt https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r225440%20(4421)/webaudio/audiobuffersource-crash-log.txt (In reply to Ryan Haddad from comment #9) > (In reply to Saam Barati from comment #6) > > (In reply to Ryan Haddad from comment #2) > > > Looking at crashlogs from the bots, this assertion failure has also been > > > seen attributed to: > > > http/tests/inspector/network/ping-type.html > > > webaudio/audiobuffersource-multi-channels.html > > > webaudio/test-basic.html > > > webaudio/up-mixing-stereo-51.html > > > webaudio/audiobuffersource-playbackrate.html > > > webaudio/oscillator-triangle.html > > > webaudio/up-mixing-mono-stereo.html > > > > Can you post crashlogs for these. > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r225482%20(1105)/http/tests/ > inspector/network/ping-type-crash-log.txt > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r225440%20(4421)/webaudio/ > audiobuffersource-crash-log.txt The second one here I'll fix in another bug. Comment on attachment 328556 [details] patch Clearing flags on attachment: 328556 Committed r225579: <https://trac.webkit.org/changeset/225579> All reviewed patches have been landed. Closing bug. (In reply to Saam Barati from comment #10) > (In reply to Ryan Haddad from comment #9) > > (In reply to Saam Barati from comment #6) > > > (In reply to Ryan Haddad from comment #2) > > > > Looking at crashlogs from the bots, this assertion failure has also been > > > > seen attributed to: > > > > http/tests/inspector/network/ping-type.html > > > > webaudio/audiobuffersource-multi-channels.html > > > > webaudio/test-basic.html > > > > webaudio/up-mixing-stereo-51.html > > > > webaudio/audiobuffersource-playbackrate.html > > > > webaudio/oscillator-triangle.html > > > > webaudio/up-mixing-mono-stereo.html > > > > > > Can you post crashlogs for these. > > https://build.webkit.org/results/ > > Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r225482%20(1105)/http/tests/ > > inspector/network/ping-type-crash-log.txt > > https://build.webkit.org/results/ > > Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r225440%20(4421)/webaudio/ > > audiobuffersource-crash-log.txt > > The second one here I'll fix in another bug. https://bugs.webkit.org/show_bug.cgi?id=180492 |