Bug 180436 – [Win64] Compile error in testmasm.cpp.

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Per Arne Vollan]

Source\JavaScriptCore\assembler\testmasm.cpp(186): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

[Per Arne Vollan]

Created attachment 328482 [details]
Patch

[Mark Lam]

Comment on attachment 328482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328482&action=review

r=me with fix.

> Source/JavaScriptCore/assembler/testmasm.cpp:186
> +    }), pointer + offset + (1ll << static_cast<int>(scale)) * length);

let's make it static_cast<size_t>(1).  I think that is what we really want.

[Per Arne Vollan]

(In reply to Mark Lam from comment #2)
> Comment on attachment 328482 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328482&action=review
> 
> r=me with fix.
> 
> > Source/JavaScriptCore/assembler/testmasm.cpp:186
> > +    }), pointer + offset + (1ll << static_cast<int>(scale)) * length);
> 
> let's make it static_cast<size_t>(1).  I think that is what we really want.

Thanks for reviewing! I will update before landing.

[Per Arne Vollan]

Committed r225536: <https://trac.webkit.org/changeset/225536/webkit>.

[Radar WebKit Bug Importer]

<rdar://problem/35863628>