Bug 180436

Summary: [Win64] Compile error in testmasm.cpp.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: JavaScriptCoreAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Per Arne Vollan 2017-12-05 12:14:13 PST
Source\JavaScriptCore\assembler\testmasm.cpp(186): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
Comment 1 Per Arne Vollan 2017-12-05 12:22:10 PST
Created attachment 328482 [details]
Patch
Comment 2 Mark Lam 2017-12-05 13:06:55 PST
Comment on attachment 328482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328482&action=review

r=me with fix.

> Source/JavaScriptCore/assembler/testmasm.cpp:186
> +    }), pointer + offset + (1ll << static_cast<int>(scale)) * length);

let's make it static_cast<size_t>(1).  I think that is what we really want.
Comment 3 Per Arne Vollan 2017-12-05 13:16:55 PST
(In reply to Mark Lam from comment #2)
> Comment on attachment 328482 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328482&action=review
> 
> r=me with fix.
> 
> > Source/JavaScriptCore/assembler/testmasm.cpp:186
> > +    }), pointer + offset + (1ll << static_cast<int>(scale)) * length);
> 
> let's make it static_cast<size_t>(1).  I think that is what we really want.

Thanks for reviewing! I will update before landing.
Comment 4 Per Arne Vollan 2017-12-05 13:42:06 PST
Committed r225536: <https://trac.webkit.org/changeset/225536/webkit>.
Comment 5 Radar WebKit Bug Importer 2017-12-05 13:43:17 PST
<rdar://problem/35863628>