Summary: | [Win64] Compile error in testmasm.cpp. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | JavaScriptCore | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Per Arne Vollan
2017-12-05 12:14:13 PST
Created attachment 328482 [details]
Patch
Comment on attachment 328482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328482&action=review r=me with fix. > Source/JavaScriptCore/assembler/testmasm.cpp:186 > + }), pointer + offset + (1ll << static_cast<int>(scale)) * length); let's make it static_cast<size_t>(1). I think that is what we really want. (In reply to Mark Lam from comment #2) > Comment on attachment 328482 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328482&action=review > > r=me with fix. > > > Source/JavaScriptCore/assembler/testmasm.cpp:186 > > + }), pointer + offset + (1ll << static_cast<int>(scale)) * length); > > let's make it static_cast<size_t>(1). I think that is what we really want. Thanks for reviewing! I will update before landing. Committed r225536: <https://trac.webkit.org/changeset/225536/webkit>. |