Bug 180433

Summary: Prefer ids and classes over tag names in selector filter
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ggaren, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2017-12-05 10:54:25 PST
There are only four slots in the filter and currently we just pick whatever identifiers we find traversing the selector from right to left. More specific selector types are on average more valuable (id > class > tag) so we should prefer them.
Attachments
patch (8.16 KB, patch)
2017-12-05 11:00 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-05 10:57:41 PST
<rdar://problem/35859103>
Antti Koivisto
Comment 2 2017-12-05 11:00:16 PST
Created attachment 328471 [details] patch
WebKit Commit Bot
Comment 3 2017-12-06 14:24:09 PST
Comment on attachment 328471 [details] patch Clearing flags on attachment: 328471 Committed r225596: <https://trac.webkit.org/changeset/225596>
WebKit Commit Bot
Comment 4 2017-12-06 14:24:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.