Summary: | [build.webkit.org] Rename mastercfg_unittest to steps_unittest | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, dbates, dean_johnson, ews-watchlist, lforschler, ossy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Aakash Jain
2017-12-05 10:30:09 PST
Created attachment 328465 [details]
Proposed patch
Might need to re-base before landing because of other patches modifying same file.
Attachment 328465 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:15: expected 2 blank lines, found 1 [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:88: expected 2 blank lines, found 1 [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:407: whitespace before ':' [pep8/E203] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:413: missing whitespace after ':' [pep8/E231] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:105: [RunJavaScriptCoreTestsTest.assertResults] Undefined variable 'RunJavaScriptCoreTests' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:114: [RunJavaScriptCoreTestsTest.test_no_regressions_old_output] Undefined variable 'SUCCESS' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:120: [RunJavaScriptCoreTestsTest.test_no_failure_new_output] Undefined variable 'SUCCESS' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:125: [RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:130: [RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:135: [RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:139: [RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:146: [RunTest262TestsTest.assertResults] Undefined variable 'RunTest262Tests' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:155: [RunTest262TestsTest.test_no_regressions_output] Undefined variable 'SUCCESS' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:162: [RunTest262TestsTest.test_failure_output] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:171: [RunTest262TestsTest.test_failures_output] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:185: [RunLLINTCLoopTestsTest.assertResults] Undefined variable 'RunLLINTCLoopTests' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:194: [RunLLINTCLoopTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:197: [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:200: [RunLLINTCLoopTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:206: [Run32bitJSCTestsTest.assertResults] Undefined variable 'Run32bitJSCTests' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:215: [Run32bitJSCTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:218: [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:221: [Run32bitJSCTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:228: [RunUnitTestsTest.assertFailures] Undefined variable 'FAILURE' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:233: [RunUnitTestsTest.assertFailures] Undefined variable 'SUCCESS' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:237: [RunUnitTestsTest.assertFailures] Undefined variable 'RunUnitTests' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:370: [SVNMirrorTest.test_CheckOutSource] Undefined variable 'CheckOutSource' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:370: [SVNMirrorTest.test_CheckOutSource] Undefined variable 'source' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:374: [SVNMirrorTest.test_CheckOutSource] Undefined variable 'c' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:389: [BuildStepsConstructorTest.generateTests] Undefined variable 'c' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:481: [BuildStepsTest.generateTests] Undefined variable 'c' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:498: [BuildStepsTest.test_unnecessary_expected_results] Undefined variable 'c' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:508: [RunAndUploadPerfTestsTest.assertResults] Undefined variable 'RunAndUploadPerfTests' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:542: [RunBenchmarkTest.assertResults] Undefined variable 'RunBenchmarkTests' [pylint/E0602] [5]
Total errors found: 34 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 328465 [details]
Proposed patch
rs=me
Fixed style issues in https://bugs.webkit.org/show_bug.cgi?id=180439 Committed r225548: <https://trac.webkit.org/changeset/225548> |