Bug 180428

Summary: Unskip some more Service Worker tests
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch none

Description youenn fablet 2017-12-05 08:57:02 PST
Unskip some more Service Worker tests
Comment 1 youenn fablet 2017-12-05 08:58:39 PST
Created attachment 328456 [details]
Patch
Comment 2 Chris Dumez 2017-12-05 09:00:24 PST
Comment on attachment 328456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328456&action=review

> LayoutTests/TestExpectations:-164
> -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ]

You unskipped this one but did not rebase line it. Therefore, it will times out if it passes on EWS.
Comment 3 Chris Dumez 2017-12-05 09:00:42 PST
Comment on attachment 328456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328456&action=review

>> LayoutTests/TestExpectations:-164
>> -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ]
> 
> You unskipped this one but did not rebase line it. Therefore, it will times out if it passes on EWS.

Expected results say:
"Harness Error (TIMEOUT), message = null"
Comment 4 EWS Watchlist 2017-12-05 10:21:38 PST
Comment on attachment 328456 [details]
Patch

Attachment 328456 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5502269

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html
Comment 5 EWS Watchlist 2017-12-05 10:21:39 PST
Created attachment 328462 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 6 Chris Dumez 2017-12-05 10:22:19 PST
(In reply to Build Bot from comment #4)
> Comment on attachment 328456 [details]
> Patch
> 
> Attachment 328456 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/5502269
> 
> New failing tests:
> imported/w3c/web-platform-tests/service-workers/service-worker/unregister-
> then-register-new-script.https.html

I was right!
Comment 7 youenn fablet 2017-12-05 11:01:10 PST
Created attachment 328473 [details]
Patch
Comment 8 WebKit Commit Bot 2017-12-05 13:24:26 PST
Comment on attachment 328473 [details]
Patch

Clearing flags on attachment: 328473

Committed r225532: <https://trac.webkit.org/changeset/225532>
Comment 9 WebKit Commit Bot 2017-12-05 13:24:27 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-12-06 16:48:25 PST
<rdar://problem/35896621>