RESOLVED FIXED 180428
Unskip some more Service Worker tests 
https://bugs.webkit.org/show_bug.cgi?id=180428
Summary Unskip some more Service Worker tests
youenn fablet
Reported 2017-12-05 08:57:02 PST
Unskip some more Service Worker tests
Attachments
Patch (4.06 KB, patch)
2017-12-05 08:58 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.11 MB, application/zip)
2017-12-05 10:21 PST, EWS Watchlist 		no flags
Details
Patch (5.68 KB, patch)
2017-12-05 11:01 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-05 08:58:39 PST
Created attachment 328456 [details] Patch
Chris Dumez
Comment 2 2017-12-05 09:00:24 PST
Comment on attachment 328456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328456&action=review > LayoutTests/TestExpectations:-164 > -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ] You unskipped this one but did not rebase line it. Therefore, it will times out if it passes on EWS.
Chris Dumez
Comment 3 2017-12-05 09:00:42 PST
Comment on attachment 328456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328456&action=review >> LayoutTests/TestExpectations:-164 >> -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ] > > You unskipped this one but did not rebase line it. Therefore, it will times out if it passes on EWS. Expected results say: "Harness Error (TIMEOUT), message = null"
EWS Watchlist
Comment 4 2017-12-05 10:21:38 PST
Comment on attachment 328456 [details] Patch Attachment 328456 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5502269 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html
EWS Watchlist
Comment 5 2017-12-05 10:21:39 PST
Created attachment 328462 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Chris Dumez
Comment 6 2017-12-05 10:22:19 PST
(In reply to Build Bot from comment #4) > Comment on attachment 328456 [details] > Patch > > Attachment 328456 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/5502269 > > New failing tests: > imported/w3c/web-platform-tests/service-workers/service-worker/unregister- > then-register-new-script.https.html I was right!
youenn fablet
Comment 7 2017-12-05 11:01:10 PST
Created attachment 328473 [details] Patch
WebKit Commit Bot
Comment 8 2017-12-05 13:24:26 PST
Comment on attachment 328473 [details] Patch Clearing flags on attachment: 328473 Committed r225532: <https://trac.webkit.org/changeset/225532>
WebKit Commit Bot
Comment 9 2017-12-05 13:24:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-12-06 16:48:25 PST
<rdar://problem/35896621>
Note You need to log in before you can comment on or make changes to this bug.