Bug 180380

Summary: Web Inspector: Details section headers overlap Classes container in the Computed Styles panel
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, lforschler, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Overlapping header
none
Patch
none
Patch for landing none

Matt Baker
Reported 2017-12-04 14:49:03 PST
Created attachment 328392 [details] [Image] Overlapping header Summary: Details section headers overlap Classes container in the Computed Styles panel. Steps to Reproduce: 1. Open Elements > Computed Styles 2. Toggle "Show All", forcing the panel contents to scroll vertically 3. Click the "Classes" button at the bottom to expand the sub-panel 4. Scroll past the Properties section to Box Model => Box Model header overlaps the Classes sub-panel
Attachments
[Image] Overlapping header (224.82 KB, image/png)
2017-12-04 14:49 PST, Matt Baker 		no flags
Details
Patch (1.65 KB, patch)
2017-12-04 14:50 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.59 KB, patch)
2017-12-06 12:00 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-12-04 14:50:09 PST
Created attachment 328393 [details] Patch
WebKit Commit Bot
Comment 2 2017-12-05 22:35:42 PST
Comment on attachment 328393 [details] Patch Rejecting attachment 328393 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 328393, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 76da3136a06d3d9a391..6d3df5707fbafb036dbf92ba09c83742027efd33 100644 |--- Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css (revision 0) |+++ Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5511123
Matt Baker
Comment 3 2017-12-06 12:00:36 PST
Created attachment 328603 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-12-06 14:21:13 PST
Comment on attachment 328603 [details] Patch for landing Clearing flags on attachment: 328603 Committed r225595: <https://trac.webkit.org/changeset/225595>
WebKit Commit Bot
Comment 5 2017-12-06 14:21:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-12-06 15:48:26 PST
<rdar://problem/35894911>
Note You need to log in before you can comment on or make changes to this bug.