Summary: | [Web App Manifest] Add SPI for applying a manifest to a top-level browsing context | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Quesada <david_quesada> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, ggaren, joepeck, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
David Quesada
2017-12-04 12:09:38 PST
Actually, I already had a radar for this one :/ rdar://problem/34748067 Created attachment 328383 [details]
Patch
Patch for review. This depends on 180294.
Comment on attachment 328383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328383&action=review r=me > Source/WebCore/page/PageConfiguration.h:81 > + std::optional<ApplicationManifest> applicationManifest { std::nullopt }; No need to specify nullopt here. The default constructor will do that for you. Created attachment 328532 [details]
Patch for landing
Created attachment 328636 [details]
Patch for landing (v2)
Attempt to fix the EWS errors.
Comment on attachment 328636 [details] Patch for landing (v2) View in context: https://bugs.webkit.org/attachment.cgi?id=328636&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:70 > +@property (nonatomic, setter=_setApplicationManifest:) _WKApplicationManifest *_applicationManifest; This should have a API_AVAILABLE macro with TBA values. Certainly mac, maybe iOS? @property ... _WKApplicationManifest *_applicationManifest WK_API_AVAILABLE(macosx(WK_MAC_TBA)); Created attachment 328655 [details]
Patch for landing (v3)
Now with API availability annotation
Created attachment 328657 [details]
Patch for landing (v4)
Addressed one more piece of feedback from JoePeck: removed #if guards around a class forward declaration.
Comment on attachment 328657 [details] Patch for landing (v4) Clearing flags on attachment: 328657 Committed r225615: <https://trac.webkit.org/changeset/225615> All reviewed patches have been landed. Closing bug. |