Bug 180356
| Summary: | Generate text encoding names and aliases from encodings.json (plus WebKit-specific data) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> |
| Component: | Text | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | achristensen, annevk, mmaxfield |
| Priority: | P2 | ||
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 179303 | ||
Maciej Stachowiak
Generate text encoding names and aliases from encodings.json (plus WebKit-specific data). Doing it this way will remove some grungy macros that define our name tables, and will make it more obvious where we diverge from the Encoding Standard. It might be necessary to fix #19307 first to accomplish this cleanly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Anne van Kesteren
Alex, is this still something we need after the various rounds of cleanup you did?
Anne van Kesteren
Per https://github.com/web-platform-tests/wpt/pull/36096 this might still be good. We do acknowledge the x-mac-* encodings, but I don't see EUC-TW mentioned there as being non-compliant or intentional.
Anne van Kesteren
Source/WebCore/PAL/pal/text/TextCodecICU.cpp maintains a registry now. It lists some non-standard encodings such as EUC-TW, but that is something to address separately.
The only slight further improvement here would be generating it from encodings.json, but it's not at all clear that is worth the effort given the rate of change.