Bug 180354

Summary: Remove duplicates from selector filter hashes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, ggaren, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Antti Koivisto
Reported 2017-12-04 07:14:05 PST
We have only four slots for hashes in RuleSet (and adding more regresses performance). To use them better we should eliminate duplicates.
Attachments
patch (9.58 KB, patch)
2017-12-04 07:36 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (9.58 KB, patch)
2017-12-04 07:41 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-04 07:18:35 PST
<rdar://problem/35829039>
Antti Koivisto
Comment 2 2017-12-04 07:36:08 PST
Created attachment 328345 [details] patch
EWS Watchlist
Comment 3 2017-12-04 07:38:07 PST
Attachment 328345 [details] did not pass style-queue: ERROR: Source/WebCore/css/SelectorFilter.cpp:102: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 4 2017-12-04 07:41:47 PST
Created attachment 328346 [details] patch
WebKit Commit Bot
Comment 5 2017-12-04 10:37:04 PST
Comment on attachment 328346 [details] patch Clearing flags on attachment: 328346 Committed r225482: <https://trac.webkit.org/changeset/225482>
WebKit Commit Bot
Comment 6 2017-12-04 10:37:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.