Bug 180354 - Remove duplicates from selector filter hashes
Summary: Remove duplicates from selector filter hashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-04 07:14 PST by Antti Koivisto
Modified: 2017-12-04 10:37 PST (History)
6 users (show)

See Also:

Attachments
patch (9.58 KB, patch)
2017-12-04 07:36 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (9.58 KB, patch)
2017-12-04 07:41 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-12-04 07:14:05 PST 
We have only four slots for hashes in RuleSet (and adding more regresses performance). To use them better we should eliminate duplicates.
Comment 1 Radar WebKit Bug Importer 2017-12-04 07:18:35 PST 
<rdar://problem/35829039>
Comment 2 Antti Koivisto 2017-12-04 07:36:08 PST 
Created attachment 328345 [details]
patch
Comment 3 EWS Watchlist 2017-12-04 07:38:07 PST 
Attachment 328345 [details] did not pass style-queue:


ERROR: Source/WebCore/css/SelectorFilter.cpp:102:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2017-12-04 07:41:47 PST 
Created attachment 328346 [details]
patch
Comment 5 WebKit Commit Bot 2017-12-04 10:37:04 PST 
Comment on attachment 328346 [details]
patch

Clearing flags on attachment: 328346

Committed r225482: <https://trac.webkit.org/changeset/225482>
Comment 6 WebKit Commit Bot 2017-12-04 10:37:05 PST 
All reviewed patches have been landed.  Closing bug.