Bug 180353

Summary: Make ScrollingTreeNode::enclosingFrameNode return the node itself for frame nodes
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, jamesr, luiz, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 175135    
Bug Blocks: 149264, 173833    
Attachments:
Description Flags
Patch tonikitoo: review+

Frédéric Wang (:fredw)
Reported 2017-12-04 06:13:26 PST
This function was introduced in bug 175135 to solve an issue with overflow nodes, but it should really include the frame itself when we implement ios frame scrolling.
Attachments
Patch (4.92 KB, patch)
2017-12-04 06:27 PST, Frédéric Wang (:fredw) 		tonikitoo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2017-12-04 06:27:10 PST
Created attachment 328343 [details] Patch
Antonio Gomes
Comment 2 2017-12-04 06:54:56 PST
Comment on attachment 328343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328343&action=review > Source/WebCore/ChangeLog:8 > + This function was introduced in bug 175135 to solve a rendering bug with fixed nodes in fixed nodes -> fixed positioned nodes, for clarity. > Source/WebCore/ChangeLog:20 > + (WebCore::ScrollingTreeNode::enclosingFrameNode const): Deleted. Renamed to make explicit nit: "Deleted" here is confusing. please remove.
Frédéric Wang (:fredw)
Comment 3 2017-12-04 08:46:01 PST
Committed r225480: <https://trac.webkit.org/changeset/225480>
Radar WebKit Bug Importer
Comment 4 2017-12-06 16:29:33 PST
<rdar://problem/35896089>
Note You need to log in before you can comment on or make changes to this bug.