| Summary: | Rename DestroyFunc to avoid redefinition on unified build | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||||||
| Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, darin, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Caio Lima
2017-12-03 08:56:03 PST
Created attachment 328296 [details]
Patch
Comment on attachment 328296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328296&action=review R=me. I recommend also removing the anonymous namespaces that wrap these in this patch. > Source/JavaScriptCore/heap/HeapCellType.cpp:40 > +struct HeapDestroyFunc { Maybe call this one: DefaultDestroyFunc. Created attachment 328303 [details]
Patch
Comment on attachment 328303 [details]
Patch
Applied changes
Comment on attachment 328303 [details] Patch Rejecting attachment 328303 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 328303, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/5478869 Created attachment 328304 [details]
Patch
Thanks for the review! Comment on attachment 328304 [details] Patch Clearing flags on attachment: 328304 Committed r225464: <https://trac.webkit.org/changeset/225464> All reviewed patches have been landed. Closing bug. |