Bug 180335

Summary: Rename DestroyFunc to avoid redefinition on unified build
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ews, fpizlo, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Caio Lima 2017-12-03 08:56:03 PST
...
Comment 1 Caio Lima 2017-12-03 09:26:48 PST
Created attachment 328296 [details]
Patch
Comment 2 Filip Pizlo 2017-12-03 12:18:25 PST
Comment on attachment 328296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328296&action=review

R=me. I recommend also removing the anonymous namespaces that wrap these in this patch.

> Source/JavaScriptCore/heap/HeapCellType.cpp:40
> +struct HeapDestroyFunc {

Maybe call this one: DefaultDestroyFunc.
Comment 3 Caio Lima 2017-12-03 13:56:09 PST
Created attachment 328303 [details]
Patch
Comment 4 Caio Lima 2017-12-03 13:57:07 PST
Comment on attachment 328303 [details]
Patch

Applied changes
Comment 5 WebKit Commit Bot 2017-12-03 13:58:07 PST
Comment on attachment 328303 [details]
Patch

Rejecting attachment 328303 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 328303, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/5478869
Comment 6 Caio Lima 2017-12-03 14:10:52 PST
Created attachment 328304 [details]
Patch
Comment 7 Caio Lima 2017-12-03 14:12:30 PST
Thanks for the review!
Comment 8 WebKit Commit Bot 2017-12-03 15:00:50 PST
Comment on attachment 328304 [details]
Patch

Clearing flags on attachment: 328304

Committed r225464: <https://trac.webkit.org/changeset/225464>
Comment 9 WebKit Commit Bot 2017-12-03 15:00:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-12-03 15:01:23 PST
<rdar://problem/35820544>