Bug 180335

Summary: Rename DestroyFunc to avoid redefinition on unified build
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Caio Lima
Reported 2017-12-03 08:56:03 PST
...
Attachments
Patch (7.31 KB, patch)
2017-12-03 09:26 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (8.40 KB, patch)
2017-12-03 13:56 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (8.40 KB, patch)
2017-12-03 14:10 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2017-12-03 09:26:48 PST
Created attachment 328296 [details] Patch
Filip Pizlo
Comment 2 2017-12-03 12:18:25 PST
Comment on attachment 328296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328296&action=review R=me. I recommend also removing the anonymous namespaces that wrap these in this patch. > Source/JavaScriptCore/heap/HeapCellType.cpp:40 > +struct HeapDestroyFunc { Maybe call this one: DefaultDestroyFunc.
Caio Lima
Comment 3 2017-12-03 13:56:09 PST
Created attachment 328303 [details] Patch
Caio Lima
Comment 4 2017-12-03 13:57:07 PST
Comment on attachment 328303 [details] Patch Applied changes
WebKit Commit Bot
Comment 5 2017-12-03 13:58:07 PST
Comment on attachment 328303 [details] Patch Rejecting attachment 328303 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 328303, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/5478869
Caio Lima
Comment 6 2017-12-03 14:10:52 PST
Created attachment 328304 [details] Patch
Caio Lima
Comment 7 2017-12-03 14:12:30 PST
Thanks for the review!
WebKit Commit Bot
Comment 8 2017-12-03 15:00:50 PST
Comment on attachment 328304 [details] Patch Clearing flags on attachment: 328304 Committed r225464: <https://trac.webkit.org/changeset/225464>
WebKit Commit Bot
Comment 9 2017-12-03 15:00:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-12-03 15:01:23 PST
<rdar://problem/35820544>
Note You need to log in before you can comment on or make changes to this bug.