Bug 180313

Summary: Web Automation: add flag to preserve legacy page screenshot behavior
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebDriverAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, commit-queue, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2017-12-02 10:42:47 PST
For the legacy protocol supported by safaridriver, people expect a screenshot of the entire contents, not the viewport. And there is no workaround because Element Screenshot is not supported by the driver. Instead, add a legacy behavior flag. This can be removed when safaridriver only needs to support W3C protocol.
Attachments
Patch (13.89 KB, patch)
2017-12-04 13:45 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-12-02 10:43:11 PST
<rdar://problem/34379930>
Blaze Burg
Comment 2 2017-12-04 13:45:07 PST
Created attachment 328385 [details] Patch
Joseph Pecoraro
Comment 3 2017-12-04 13:48:15 PST
Comment on attachment 328385 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-12-04 16:06:28 PST
Comment on attachment 328385 [details] Patch Clearing flags on attachment: 328385 Committed r225501: <https://trac.webkit.org/changeset/225501>
WebKit Commit Bot
Comment 5 2017-12-04 16:06:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.