Bug 180313 - Web Automation: add flag to preserve legacy page screenshot behavior
Summary: Web Automation: add flag to preserve legacy page screenshot behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-02 10:42 PST by BJ Burg
Modified: 2017-12-04 16:06 PST (History)
5 users (show)

See Also:

Attachments
Patch (13.89 KB, patch)
2017-12-04 13:45 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-12-02 10:42:47 PST 
For the legacy protocol supported by safaridriver, people expect a screenshot of the entire contents, not the viewport. And there is no workaround because Element Screenshot is not supported by the driver. Instead, add a legacy behavior flag. This can be removed when safaridriver only needs to support W3C protocol.
Comment 1 BJ Burg 2017-12-02 10:43:11 PST 
<rdar://problem/34379930>
Comment 2 BJ Burg 2017-12-04 13:45:07 PST 
Created attachment 328385 [details]
Patch
Comment 3 Joseph Pecoraro 2017-12-04 13:48:15 PST 
Comment on attachment 328385 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-12-04 16:06:28 PST 
Comment on attachment 328385 [details]
Patch

Clearing flags on attachment: 328385

Committed r225501: <https://trac.webkit.org/changeset/225501>
Comment 5 WebKit Commit Bot 2017-12-04 16:06:30 PST 
All reviewed patches have been landed.  Closing bug.