Bug 180291

Summary:

Let's scramble ClassInfo pointers in cells.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	jfbastien: review+
patch for landing + speculative build fix	none
x86_64 benchmark result.	none

Description Mark Lam 2017-12-01 15:32:24 PST

patch coming.

Comment 1 Radar WebKit Bug Importer 2017-12-01 15:32:59 PST

<rdar://problem/35807620>

Comment 2 Mark Lam 2017-12-01 15:40:02 PST

Created attachment 328170 [details]
proposed patch.

Comment 3 EWS Watchlist 2017-12-01 15:42:29 PST

Attachment 328170 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp:31:  g_classInfoScrambledPtrKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp:32:  g_masmScrambledPtrKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 JF Bastien 2017-12-01 15:49:46 PST

Comment on attachment 328170 [details]
proposed patch.

r=me

Comment 5 Mark Lam 2017-12-01 16:17:20 PST

Created attachment 328180 [details]
patch for landing + speculative build fix

Comment 6 EWS Watchlist 2017-12-01 16:19:30 PST

Attachment 328180 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp:31:  g_classInfoScrambledPtrKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp:32:  g_masmScrambledPtrKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Mark Lam 2017-12-01 16:48:28 PST

Created attachment 328186 [details]
x86_64 benchmark result.

Perf appears to be neutral.

Comment 8 Mark Lam 2017-12-01 17:13:46 PST

Thanks for the review.  Landed in r225437: <http://trac.webkit.org/r225437>.