Summary: | [css-grid] Rename gutter properties to remove "grid-" prefix | ||
---|---|---|---|
Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> |
Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, jfernandez, rego, rniwa, simon.fraser, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=761904 | ||
Bug Depends on: | 182004 | ||
Bug Blocks: | |||
Attachments: |
Description
Javier Fernandez
2017-12-01 15:29:19 PST
Link to the CSS WG GitHub issue: https://github.com/w3c/csswg-drafts/issues/1696 And the commit introducing the change on the spec: https://github.com/w3c/csswg-drafts/commit/8f243616df9b967ae546459e955ce0186188b54b Created attachment 332710 [details]
Patch
Not ready for review yet as it needs to import several WPT tests that will land with the Blink patch.
Attachment 332710 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:22: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 332710 [details] Patch Attachment 332710 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6269300 New failing tests: fast/css-grid-layout/grid-shorthand-get-set.html Created attachment 332727 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 332710 [details] Patch Attachment 332710 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6268749 New failing tests: fast/css-grid-layout/grid-shorthand-get-set.html Created attachment 332728 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 332710 [details] Patch Attachment 332710 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6268873 New failing tests: fast/css-grid-layout/grid-shorthand-get-set.html Created attachment 332729 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 332710 [details] Patch Attachment 332710 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6270998 New failing tests: fast/css-grid-layout/grid-shorthand-get-set.html Created attachment 332732 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 332755 [details]
Patch
Attachment 332755 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:22: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 333067 [details]
Patch
Patch ready for review, including the WPT tests.
Comment on attachment 333067 [details] Patch Attachment 333067 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6363080 Number of test failures exceeded the failure limit. Created attachment 333068 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 333067 [details] Patch Attachment 333067 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6363085 Number of test failures exceeded the failure limit. Created attachment 333069 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 333067 [details] Patch Attachment 333067 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6363088 Number of test failures exceeded the failure limit. Created attachment 333070 [details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 333071 [details]
Patch
Created attachment 333072 [details]
Patch
Comment on attachment 333072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333072&action=review > Source/WebCore/ChangeLog:8 > + [css-grid] Rename gutter properties to remove "grid-" prefix This line looks like duplicated, please delete it. Created attachment 333075 [details]
Patch for landing
Comment on attachment 333072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333072&action=review Thanks for the review. >> Source/WebCore/ChangeLog:8 >> + [css-grid] Rename gutter properties to remove "grid-" prefix > > This line looks like duplicated, please delete it. Done. The commit-queue encountered the following flaky tests while processing attachment 333075 [details]: media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html bug 169158 (authors: graouts@apple.com and ryanhaddad@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 333075 [details]: imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.html bug 182481 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 333075 [details] Patch for landing Clearing flags on attachment: 333075 Committed r228095: <https://trac.webkit.org/changeset/228095> All reviewed patches have been landed. Closing bug. |