Bug 180278

Summary: [build.webkit.org] Move python code to load config from master.cfg in separate file
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, dean_johnson, ews-watchlist, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180180
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2017-12-01 13:52:59 PST
master.cfg is a configuration file. It should contain only the configuration. All the logic (python code) should be in corresponding python files. Currently it contains lot of python code to load and parse config file. It should be moved to a separate python file.
Attachments
Proposed patch (12.26 KB, patch)
2017-12-01 13:57 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-12-01 13:57:03 PST
Created attachment 328152 [details] Proposed patch
EWS Watchlist
Comment 2 2017-12-01 14:00:31 PST
Attachment 328152 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:76: whitespace before ')' [pep8/E202] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:88: deprecated form of raising exception [pep8/W602] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-12-01 16:39:36 PST
Comment on attachment 328152 [details] Proposed patch Clearing flags on attachment: 328152 Committed r225433: <https://trac.webkit.org/changeset/225433>
WebKit Commit Bot
Comment 4 2017-12-01 16:39:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-12-01 16:40:30 PST
<rdar://problem/35809148>
Note You need to log in before you can comment on or make changes to this bug.