Bug 180273

Summary: WebAssembly: stack trace improvement follow-ups
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: WebAssemblyAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jfbastien, joepeck, keith_miller, mark.lam, msaboff, rmorisset, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 179343    
Bug Blocks:    
Attachments:
Description Flags
patch
saam: review+, saam: commit-queue-
patch none

Description JF Bastien 2017-12-01 13:08:10 PST 
Follow-up on comments after #179343 got committed.
Comment 1 JF Bastien 2017-12-01 13:09:55 PST 
Created attachment 328142 [details]
patch
Comment 2 Saam Barati 2017-12-01 13:34:22 PST 
Comment on attachment 328142 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328142&action=review

> Source/JavaScriptCore/wasm/WasmNameSection.h:53
> +    WTF_MAKE_NONCOPYABLE(NameSection);

We usually put this at the very top of classes/structs.
Comment 3 JF Bastien 2017-12-01 13:45:44 PST 
Created attachment 328150 [details]
patch
Comment 4 WebKit Commit Bot 2017-12-01 14:19:08 PST 
Comment on attachment 328150 [details]
patch

Clearing flags on attachment: 328150

Committed r225416: <https://trac.webkit.org/changeset/225416>
Comment 5 WebKit Commit Bot 2017-12-01 14:19:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-12-01 14:21:07 PST 
<rdar://problem/35805673>