Bug 180221

Summary:

Fix some NSOperationQueue leaks

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebKit Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, inspector-bugzilla-changes, joepeck, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	thorton: review+, thorton: commit-queue+
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2017-11-30 15:30:57 PST

Fix some NSOperationQueue leaks

There are some instances of [NSOperationQueue new] that aren't being released. These will be leaks.

Caught by searching for general uses of " new]" in Source.

Comment 1 Joseph Pecoraro 2017-11-30 15:31:44 PST

Created attachment 328041 [details]
[PATCH] Proposed Fix

Comment 2 Joseph Pecoraro 2017-11-30 15:32:55 PST

Err not Web Inspector... Let me fix ChangeLog.

Comment 3 Joseph Pecoraro 2017-11-30 15:33:50 PST

Created attachment 328042 [details]
[PATCH] Proposed Fix

Comment 4 Wenson Hsieh 2017-11-30 15:47:38 PST

Comment on attachment 328042 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=328042&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3726
> +            RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue new]);

Nit - auto here?

> Source/WebKitLegacy/mac/WebView/WebView.mm:6732
> +            RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue new]);

Ditto.

Comment 5 WebKit Commit Bot 2017-11-30 16:18:11 PST

Comment on attachment 328042 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 328042

Committed r225369: <https://trac.webkit.org/changeset/225369>

Comment 6 WebKit Commit Bot 2017-11-30 16:18:13 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Radar WebKit Bug Importer 2017-11-30 16:20:54 PST

<rdar://problem/35785793>