| Summary: | Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
| Component: | WebKit2 | Assignee: | Daniel Bates <dbates> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | iOS 11 | ||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Bates
2017-11-30 14:27:53 PST
Created attachment 328029 [details]
Patch
Created attachment 328040 [details]
Patch
Comment on attachment 328040 [details]
Patch
We should make API tests work on both platforms, too.
(In reply to Alex Christensen from comment #4) > Comment on attachment 328040 [details] > Patch > > We should make API tests work on both platforms, too. Do you mind if I make this test run on iOS in a follow up bug? The test makes use of TestWKWebView’s mouseUpAtPoint() to click the alternative presentation button. And this function is only implemented on Mac. We either need to implement the function for iOS or we need to update the existing unit test to trigger the button using another mechanism. (In reply to Daniel Bates from comment #5) > (In reply to Alex Christensen from comment #4) > > Comment on attachment 328040 [details] > > Patch > > > > We should make API tests work on both platforms, too. > > Do you mind if I make this test run on iOS in a follow up bug? The test > makes use of TestWKWebView’s mouseUpAtPoint() to click the alternative > presentation button. And this function is only implemented on Mac. We either > need to implement the function for iOS Teaching TestWKWebView to simulate a mouse click/tap on iOS would be more beneficial to the project. We have an existing bug to cover this, bug #172614. Committed r225372: <https://trac.webkit.org/changeset/225372> |