Bug 180218

Summary:

Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit2

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 11

Attachments:

Description	Flags
Patch	none
Patch	achristensen: review+

Daniel Bates

Reported 2017-11-30 14:27:53 PST

Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS.

Attachments
Patch (8.59 KB, patch) 2017-11-30 14:30 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (10.30 KB, patch) 2017-11-30 15:30 PST, Daniel Bates	achristensen: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-11-30 14:28:40 PST

<rdar://problem/35782555>

Daniel Bates

Comment 2 2017-11-30 14:30:00 PST

Created attachment 328029 [details] Patch

Daniel Bates

Comment 3 2017-11-30 15:30:02 PST

Created attachment 328040 [details] Patch

Alex Christensen

Comment 4 2017-11-30 15:34:58 PST

Comment on attachment 328040 [details] Patch We should make API tests work on both platforms, too.

Daniel Bates

Comment 5 2017-11-30 15:59:37 PST

(In reply to Alex Christensen from comment #4) > Comment on attachment 328040 [details] > Patch > > We should make API tests work on both platforms, too. Do you mind if I make this test run on iOS in a follow up bug? The test makes use of TestWKWebView’s mouseUpAtPoint() to click the alternative presentation button. And this function is only implemented on Mac. We either need to implement the function for iOS or we need to update the existing unit test to trigger the button using another mechanism.

Daniel Bates

Comment 6 2017-11-30 16:48:23 PST

(In reply to Daniel Bates from comment #5) > (In reply to Alex Christensen from comment #4) > > Comment on attachment 328040 [details] > > Patch > > > > We should make API tests work on both platforms, too. > > Do you mind if I make this test run on iOS in a follow up bug? The test > makes use of TestWKWebView’s mouseUpAtPoint() to click the alternative > presentation button. And this function is only implemented on Mac. We either > need to implement the function for iOS Teaching TestWKWebView to simulate a mouse click/tap on iOS would be more beneficial to the project. We have an existing bug to cover this, bug #172614.

Daniel Bates

Comment 7 2017-11-30 16:51:23 PST

Committed r225372: <https://trac.webkit.org/changeset/225372>

Note You need to log in before you can comment on or make changes to this bug.