| Summary: | [JSC] Remove easy toRemove & map.remove() use in OAS phase | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 180225 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2017-11-30 11:17:04 PST
Created attachment 327997 [details]
Patch
Comment on attachment 327997 [details]
Patch
r=me
Committed r225362: <https://trac.webkit.org/changeset/225362> Re-opened since this is blocked by bug 180225 It seems that DFGArgumentsEliminationPhase's change is bad one. But other ones are OK. But basically this is optimization. I would like to keep applying this only to super simple and apparently correct ones. Like ones in DFGObjectAllocationSinkingPhase.cpp. I think applying this to DFGObjectAllocationSinkingPhase.cpp is worth doing since basically DFGObjectAllocationSinkingPhase.cpp is known as super slow. I'll only apply this change to DFGObjectAllocationSinkingPhase.cpp. Created attachment 328051 [details]
Patch
Comment on attachment 328051 [details]
Patch
r=me
Comment on attachment 328051 [details]
Patch
Thank you!
Comment on attachment 328051 [details] Patch Clearing flags on attachment: 328051 Committed r225375: <https://trac.webkit.org/changeset/225375> All reviewed patches have been landed. Closing bug. |