Bug 180203

Summary: Make WorkerThread lifetime much more predictable
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brady Eidson
Reported 2017-11-30 10:09:41 PST
Make WorkerThread lifetime much more predictable Right now it's... not.
Attachments
Patch (3.41 KB, patch)
2017-11-30 10:48 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (3.40 KB, patch)
2017-11-30 11:36 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-11-30 10:48:04 PST
Created attachment 327994 [details] Patch
Chris Dumez
Comment 2 2017-11-30 10:59:51 PST
Comment on attachment 327994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327994&action=review r=me with a comment. > Source/WebCore/workers/WorkerThread.cpp:237 > + RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis)] { }); Should probably be a callOnMainThread() since we're in WebCore (and this code is likely used by iOS WK1)?
Brady Eidson
Comment 3 2017-11-30 11:36:10 PST
Created attachment 327999 [details] Patch
Brady Eidson
Comment 4 2017-11-30 11:36:25 PST
Comment on attachment 327999 [details] Patch Will cq+ after EWS
WebKit Commit Bot
Comment 5 2017-11-30 13:01:16 PST
Comment on attachment 327999 [details] Patch Clearing flags on attachment: 327999 Committed r225343: <https://trac.webkit.org/changeset/225343>
WebKit Commit Bot
Comment 6 2017-11-30 13:01:17 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-30 13:03:58 PST
<rdar://problem/35780268>
Note You need to log in before you can comment on or make changes to this bug.