Bug 180202

Summary: [Mac] remove unneeded RetainPtr use introduced in r225142
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Darin Adler
Reported 2017-11-30 09:58:15 PST
REGRESSION (r225142): [Cocoa] over-release of lookup options
Attachments
Patch (15.46 KB, patch)
2017-11-30 10:11 PST, Darin Adler 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-11-30 10:11:22 PST
Created attachment 327986 [details] Patch
Darin Adler
Comment 2 2017-11-30 10:17:11 PST
Committed r225331: <https://trac.webkit.org/changeset/225331>
Radar WebKit Bug Importer
Comment 3 2017-11-30 10:20:22 PST
<rdar://problem/35775457>
Tim Horton
Comment 4 2017-11-30 10:33:15 PST
Comment on attachment 327986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327986&action=review > Source/WebCore/ChangeLog:9 > + of RetainPtr because these use overrelease. Heh, tiny phone review did not catch "overrelease" instead of "autorelease"
Darin Adler
Comment 5 2017-11-30 15:13:53 PST
Comment on attachment 327986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327986&action=review >> Source/WebCore/ChangeLog:9 >> + of RetainPtr because these use overrelease. > > Heh, tiny phone review did not catch "overrelease" instead of "autorelease" But if you look at what I actually checked in, you’ll see I caught it in time!
Tim Horton
Comment 6 2017-11-30 15:33:09 PST
Excellent :)
Note You need to log in before you can comment on or make changes to this bug.