Bug 180202

Summary:

[Mac] remove unneeded RetainPtr use introduced in r225142

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Darin Adler 2017-11-30 09:58:15 PST

REGRESSION (r225142): [Cocoa] over-release of lookup options

Comment 1 Darin Adler 2017-11-30 10:11:22 PST

Created attachment 327986 [details]
Patch

Comment 2 Darin Adler 2017-11-30 10:17:11 PST

Committed r225331: <https://trac.webkit.org/changeset/225331>

Comment 3 Radar WebKit Bug Importer 2017-11-30 10:20:22 PST

<rdar://problem/35775457>

Comment 4 Tim Horton 2017-11-30 10:33:15 PST

Comment on attachment 327986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327986&action=review

> Source/WebCore/ChangeLog:9
> +        of RetainPtr because these use overrelease.

Heh, tiny phone review did not catch "overrelease" instead of "autorelease"

Comment 5 Darin Adler 2017-11-30 15:13:53 PST

Comment on attachment 327986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327986&action=review

>> Source/WebCore/ChangeLog:9
>> +        of RetainPtr because these use overrelease.
> 
> Heh, tiny phone review did not catch "overrelease" instead of "autorelease"

But if you look at what I actually checked in, you’ll see I caught it in time!

Comment 6 Tim Horton 2017-11-30 15:33:09 PST

Excellent :)