Bug 180184

Summary: [Attachment Support] Implement SPI for clients to update a given attachment's data
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
First pass
none
Patch
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2017-11-29 22:42:32 PST
<rdar://problem/35355731>
Attachments
First pass (25.88 KB, patch)
2017-11-29 23:09 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (25.90 KB, patch)
2017-11-30 08:13 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (37.21 KB, patch)
2017-12-01 15:04 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-11-29 23:09:22 PST
Created attachment 327955 [details] First pass
Wenson Hsieh
Comment 2 2017-11-30 08:13:50 PST
Created attachment 327978 [details] Patch
Tim Horton
Comment 3 2017-12-01 14:02:43 PST
Comment on attachment 327978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327978&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:275 > + resultError = retainPtr(error); Why even the retainPtr()?
Wenson Hsieh
Comment 4 2017-12-01 14:06:37 PST
Comment on attachment 327978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327978&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:275 >> + resultError = retainPtr(error); > > Why even the retainPtr()? True, explicit retainPtr()'s unneeded here. Removed!
Wenson Hsieh
Comment 5 2017-12-01 15:04:42 PST
Created attachment 328165 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-12-01 15:36:45 PST
Comment on attachment 328165 [details] Patch for landing Clearing flags on attachment: 328165 Committed r225422: <https://trac.webkit.org/changeset/225422>
Note You need to log in before you can comment on or make changes to this bug.