Bug 180172

Summary:

Rename ImageFrameCache to ImageSource

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Images

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, graouts, kondapallykalyan, pvollan, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none
Patch	none

Said Abou-Hallawa

Reported 2017-11-29 15:54:07 PST

This is a followup patch for https://bugs.webkit.org/show_bug.cgi?id=175595. ImageSource is the intended name after merging ImageFrameCache and ImageSource. After this patch the hierarchy will be the following: CachedImage has a pointer to Image which can be a BitmapImage BitmapImage has a pointer to ImageSource ImageSource has a pointer to ImageDecoder and a Vector<ImageFrame>

Attachments
Patch (114.67 KB, patch) 2017-11-29 16:01 PST, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.13 MB, application/zip) 2017-11-29 17:27 PST, EWS Watchlist	no flags	Details
Patch (114.67 KB, patch) 2017-11-29 19:40 PST, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (86.62 KB, patch) 2017-12-01 14:51 PST, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2017-11-29 16:01:42 PST

Created attachment 327918 [details] Patch

EWS Watchlist

Comment 2 2017-11-29 17:27:11 PST

Comment on attachment 327918 [details] Patch Attachment 327918 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5410946 New failing tests: imported/w3c/web-platform-tests/resource-timing/single-entry-per-resource.html

EWS Watchlist

Comment 3 2017-11-29 17:27:12 PST

Created attachment 327934 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Said Abou-Hallawa

Comment 4 2017-11-29 19:40:08 PST

Created attachment 327945 [details] Patch

Per Arne Vollan

Comment 5 2017-12-01 09:54:50 PST

Comment on attachment 327945 [details] Patch Looks good! R=me.

WebKit Commit Bot

Comment 6 2017-12-01 09:58:54 PST

Comment on attachment 327945 [details] Patch Rejecting attachment 327945 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 327945, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ache.h rm 'Source/WebCore/platform/graphics/ImageFrameCache.h' patching file Source/WebCore/platform/graphics/ImageSource.cpp patching file Source/WebCore/platform/graphics/ImageSource.h patching file Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp patching file Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Per Arne Vollan']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5448820

Said Abou-Hallawa

Comment 7 2017-12-01 14:51:59 PST

Created attachment 328162 [details] Patch

WebKit Commit Bot

Comment 8 2017-12-01 16:01:58 PST

Comment on attachment 328162 [details] Patch Clearing flags on attachment: 328162 Committed r225428: <https://trac.webkit.org/changeset/225428>

WebKit Commit Bot

Comment 9 2017-12-01 16:02:00 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2017-12-01 16:03:59 PST

<rdar://problem/35808350>

Note You need to log in before you can comment on or make changes to this bug.