Bug 180166

Summary: When managing context startups, make ServiceWorkerJobDataIdentifier's optional
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brady Eidson
Reported 2017-11-29 14:05:30 PST
When managing context startups, make ServiceWorkerJobDataIdentifier's optional
Attachments
Patch (20.89 KB, patch)
2017-11-29 14:08 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (20.83 KB, patch)
2017-11-29 14:44 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-11-29 14:06:08 PST
Motivation: We'll sometimes be starting SW contexts without an associated job
Brady Eidson
Comment 2 2017-11-29 14:08:34 PST
Created attachment 327902 [details] Patch
Chris Dumez
Comment 3 2017-11-29 14:10:28 PST
Comment on attachment 327902 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-11-29 14:20:01 PST
Comment on attachment 327902 [details] Patch Rejecting attachment 327902 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 327902, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e/workers/service/server/SWServerWorker.h patching file Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in patching file Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp Hunk #2 succeeded at 174 (offset 3 lines). patching file Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5408804
Chris Dumez
Comment 5 2017-11-29 14:44:02 PST
Created attachment 327911 [details] Patch
Chris Dumez
Comment 6 2017-11-29 14:44:26 PST
Comment on attachment 327911 [details] Patch Conflicted with the patch I just landed so I rebaselined it.
WebKit Commit Bot
Comment 7 2017-11-29 15:16:08 PST
Comment on attachment 327911 [details] Patch Clearing flags on attachment: 327911 Committed r225298: <https://trac.webkit.org/changeset/225298>
WebKit Commit Bot
Comment 8 2017-11-29 15:16:09 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-11-29 15:18:48 PST
<rdar://problem/35758859>
Note You need to log in before you can comment on or make changes to this bug.