| Summary: | When managing context startups, make ServiceWorkerJobDataIdentifier's optional | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Brady Eidson
2017-11-29 14:05:30 PST
Motivation: We'll sometimes be starting SW contexts without an associated job Created attachment 327902 [details]
Patch
Comment on attachment 327902 [details]
Patch
r=me
Comment on attachment 327902 [details] Patch Rejecting attachment 327902 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 327902, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e/workers/service/server/SWServerWorker.h patching file Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in patching file Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp Hunk #2 succeeded at 174 (offset 3 lines). patching file Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5408804 Created attachment 327911 [details]
Patch
Comment on attachment 327911 [details]
Patch
Conflicted with the patch I just landed so I rebaselined it.
Comment on attachment 327911 [details] Patch Clearing flags on attachment: 327911 Committed r225298: <https://trac.webkit.org/changeset/225298> All reviewed patches have been landed. Closing bug. |