Bug 180149

Summary: ensure*Connection() methods on WebProcess should return a reference
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, darin, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-11-29 10:28:18 PST
ensure*Connection() methods on WebProcess should return a reference instead of not returning anything. We can then get rid of the non-ensure variants (which called ensure internally).
Attachments
Patch (43.35 KB, patch)
2017-11-29 10:30 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-29 10:30:54 PST
Created attachment 327869 [details] Patch
WebKit Commit Bot
Comment 2 2017-11-29 11:40:16 PST
Comment on attachment 327869 [details] Patch Clearing flags on attachment: 327869 Committed r225282: <https://trac.webkit.org/changeset/225282>
WebKit Commit Bot
Comment 3 2017-11-29 11:40:17 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-11-29 11:41:23 PST
<rdar://problem/35753405>
Darin Adler
Comment 5 2017-12-02 12:40:46 PST
I don’t think these functions need ensure in their names. Just makes the function names longer. It’s not like callers care about whether the things are created lazily or not.
Note You need to log in before you can comment on or make changes to this bug.