Bug 180131

Summary: WebDriver: end point nodes are only allowed to have one session
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 180133    
Attachments:
Description Flags
Patch
bburg: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 none

Carlos Garcia Campos
Reported 2017-11-29 01:14:18 PST
We are currently keeping a map of sessions, but our service is always and end point node, so only one session can exist at a time. https://w3c.github.io/webdriver/webdriver-spec.html#dfn-maximum-active-sessions
Attachments
Patch (48.61 KB, patch)
2017-11-29 01:20 PST, Carlos Garcia Campos 		bburg: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (2.78 MB, application/zip)
2017-11-29 02:13 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-11-29 01:20:05 PST
Created attachment 327844 [details] Patch
EWS Watchlist
Comment 2 2017-11-29 01:22:33 PST
Attachment 327844 [details] did not pass style-queue: ERROR: Source/WebDriver/WebDriverService.h:119: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:349: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 3 2017-11-29 02:13:32 PST
Comment on attachment 327844 [details] Patch Attachment 327844 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5400747 New failing tests: webrtc/video-replace-muted-track.html
EWS Watchlist
Comment 4 2017-11-29 02:13:33 PST
Created attachment 327846 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Blaze Burg
Comment 5 2017-11-30 16:16:40 PST
Comment on attachment 327844 [details] Patch r=me. EWS thing is unrelated.
Carlos Garcia Campos
Comment 6 2017-12-01 01:47:26 PST
Committed r225386: <https://trac.webkit.org/changeset/225386>
Radar WebKit Bug Importer
Comment 7 2017-12-01 01:48:30 PST
<rdar://problem/35793565>
Note You need to log in before you can comment on or make changes to this bug.