Bug 180125

Summary: Web Inspector: Move console Preserve Log setting from Setting tab to Console navigation bar
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Preserve Log - Console Navigation Item
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-11-28 20:42:14 PST
Move console Preserve Log setting from Setting tab to Console navigation bar Just like we did for the Network tab. Tooltip might need some love.
Attachments
[IMAGE] Preserve Log - Console Navigation Item (47.10 KB, image/png)
2017-11-28 20:42 PST, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (7.09 KB, patch)
2017-11-28 20:46 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-11-28 20:42:43 PST
Created attachment 327824 [details] [IMAGE] Preserve Log - Console Navigation Item
Joseph Pecoraro
Comment 2 2017-11-28 20:46:12 PST
Created attachment 327825 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2017-11-28 20:46:33 PST
Comment on attachment 327825 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=327825&action=review > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:309 > +localizedStrings["Do not clear the console on new page loads"] = "Do not clear the console on new page loads"; I'm not totally happy with this tooltip but it seems fine.
Matt Baker
Comment 4 2017-11-28 20:53:39 PST
Comment on attachment 327825 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=327825&action=review r=me >> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:309 >> +localizedStrings["Do not clear the console on new page loads"] = "Do not clear the console on new page loads"; > > I'm not totally happy with this tooltip but it seems fine. At least it matches the corresponding checkbox in the Network tab.
WebKit Commit Bot
Comment 5 2017-11-28 21:08:25 PST
Comment on attachment 327825 [details] [PATCH] Proposed Fix Clearing flags on attachment: 327825 Committed r225257: <https://trac.webkit.org/changeset/225257>
WebKit Commit Bot
Comment 6 2017-11-28 21:08:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-28 21:09:27 PST
<rdar://problem/35740623>
Note You need to log in before you can comment on or make changes to this bug.