Bug 180119

Summary: Web Inspector: Cleanup Inspector classes be more consistent about using fast malloc / noncopyable
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-11-28 17:03:23 PST
Cleanup Inspector classes be more consistent about using fast malloc / noncopyable
Attachments
[PATCH] Proposed Fix (28.98 KB, patch)
2017-11-28 17:04 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-11-28 17:04:41 PST
Created attachment 327806 [details] [PATCH] Proposed Fix
EWS Watchlist
Comment 2 2017-11-28 17:06:52 PST
Attachment 327806 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:25: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.
Devin Rousso
Comment 3 2017-11-28 22:22:33 PST
Comment on attachment 327806 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=327806&action=review r=me. Nice! > Source/WebCore/ChangeLog:25 > + * inspector/agents/* Style checker thinks you're missing a semicolon. I'm not sure what to do here 🤔
WebKit Commit Bot
Comment 4 2017-11-28 23:26:45 PST
Comment on attachment 327806 [details] [PATCH] Proposed Fix Clearing flags on attachment: 327806 Committed r225263: <https://trac.webkit.org/changeset/225263>
WebKit Commit Bot
Comment 5 2017-11-28 23:26:47 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-28 23:27:26 PST
<rdar://problem/35742431>
Note You need to log in before you can comment on or make changes to this bug.