Bug 180114

Summary: Alternative Presentation Button: Provide a way to query for the replaced elements
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, rniwa, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch and layout test thorton: review+

Description Daniel Bates 2017-11-28 14:51:36 PST
Provide a way to query for the elements that were replaced by the Alternative Presentation Button.
Comment 1 Daniel Bates 2017-11-28 14:51:53 PST
<rdar://problem/35710539>
Comment 2 Daniel Bates 2017-11-28 14:59:51 PST
Created attachment 327796 [details]
Patch and layout test
Comment 3 Tim Horton 2017-12-01 16:02:38 PST
Comment on attachment 327796 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=327796&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:127
> +        [nodeHandles.get() addObject:wrapper(InjectedBundleNodeHandle::getOrCreate(element).get())];

No need for the first .get()
Comment 4 Daniel Bates 2017-12-01 16:09:12 PST
Committed r225429: <https://trac.webkit.org/changeset/225429>