Bug 180107

Summary: Clean up spanners before creating nested column context
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2017-11-28 13:47:18 PST
rdar://problem/35686655
Comment 1 zalan 2017-11-28 14:08:18 PST
Created attachment 327785 [details]
Patch
Comment 2 Antti Koivisto 2017-11-28 16:55:01 PST
Comment on attachment 327785 [details]
Patch

Can we also delete some existing code dealing with spanner moving with this?
Comment 3 zalan 2017-11-28 19:53:08 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 327785 [details]
> Patch
> 
> Can we also delete some existing code dealing with spanner moving with this?

Unfortunately RenderTreeUpdater::MultiColumn::destroyFragmentedFlow still relies on that code for cleaning up nested multicols. I am fixing destroyFragmentedFlow now
Comment 4 WebKit Commit Bot 2017-11-28 20:12:36 PST
Comment on attachment 327785 [details]
Patch

Clearing flags on attachment: 327785

Committed r225255: <https://trac.webkit.org/changeset/225255>
Comment 5 WebKit Commit Bot 2017-11-28 20:12:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-28 20:13:20 PST
<rdar://problem/35740188>