Bug 180107

Summary: Clean up spanners before creating nested column context
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

zalan
Reported 2017-11-28 13:47:18 PST
rdar://problem/35686655
Attachments
Patch (6.85 KB, patch)
2017-11-28 14:08 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2017-11-28 14:08:18 PST
Created attachment 327785 [details] Patch
Antti Koivisto
Comment 2 2017-11-28 16:55:01 PST
Comment on attachment 327785 [details] Patch Can we also delete some existing code dealing with spanner moving with this?
zalan
Comment 3 2017-11-28 19:53:08 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 327785 [details] > Patch > > Can we also delete some existing code dealing with spanner moving with this? Unfortunately RenderTreeUpdater::MultiColumn::destroyFragmentedFlow still relies on that code for cleaning up nested multicols. I am fixing destroyFragmentedFlow now
WebKit Commit Bot
Comment 4 2017-11-28 20:12:36 PST
Comment on attachment 327785 [details] Patch Clearing flags on attachment: 327785 Committed r225255: <https://trac.webkit.org/changeset/225255>
WebKit Commit Bot
Comment 5 2017-11-28 20:12:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-28 20:13:20 PST
<rdar://problem/35740188>
Note You need to log in before you can comment on or make changes to this bug.