Bug 180077

Summary: Skip back and forward buttons should not hard-code their numeric amount in localised strings
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2017-11-28 05:36:11 PST
We currently specify the skip back and skip forward buttons to use localised strings which hard-code the amount in them, for instance "Skip back 15 seconds". It would be preferable for localisation purposes to split the numeric amount in a separate localised string.
Attachments
Patch (7.84 KB, patch)
2017-11-28 05:53 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-11-28 05:36:22 PST
<rdar://problem/34306985>
Antoine Quint
Comment 2 2017-11-28 05:53:56 PST
Created attachment 327747 [details] Patch
Eric Carlson
Comment 3 2017-11-28 06:17:02 PST
Comment on attachment 327747 [details] Patch Nice test!
WebKit Commit Bot
Comment 4 2017-11-28 07:01:26 PST
Comment on attachment 327747 [details] Patch Clearing flags on attachment: 327747 Committed r225216: <https://trac.webkit.org/changeset/225216>
WebKit Commit Bot
Comment 5 2017-11-28 07:01:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.