Bug 180068

Summary:

[WinCairo] Cannot build without Internet connection

Product:

WebKit

Reporter:

Basuke Suzuki <basuke>

Component:

Tools / Tests

Assignee:

Basuke Suzuki <basuke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, basuke, commit-queue, don.olmstead, ews-watchlist, lforschler, rniwa, ross.kirsling, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
fix	achristensen: review+
fix	none
added reviewer	none
added message output	none

Basuke Suzuki

Reported 2017-11-27 22:26:03 PST

WinCairoRequirements download prevents build scripts move forward. If it was downloaded, it had better to start building without checking the libraries are latest or not.

Attachments
patch (3.09 KB, patch) 2017-11-28 22:47 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
fix (3.11 KB, patch) 2017-11-28 23:19 PST, Basuke Suzuki	achristensen: review+	Details Formatted Diff Diff
fix (3.12 KB, patch) 2017-11-30 14:36 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
added reviewer (3.12 KB, patch) 2017-11-30 14:37 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
added message output (3.46 KB, patch) 2017-11-30 14:59 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Basuke Suzuki

Comment 1 2017-11-28 22:47:13 PST

Created attachment 327837 [details] patch

EWS Watchlist

Comment 2 2017-11-28 22:49:38 PST

Attachment 327837 [details] did not pass style-queue: ERROR: Tools/Scripts/download-latest-github-release.py:128: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Basuke Suzuki

Comment 3 2017-11-28 23:19:26 PST

Created attachment 327838 [details] fix fix style

Basuke Suzuki

Comment 4 2017-11-28 23:26:21 PST

I want to work while I'm on the sky so that this patch was required.

Don Olmstead

Comment 5 2017-11-29 10:35:48 PST

Seems reasonable to me.

Ross Kirsling

Comment 6 2017-11-29 11:22:51 PST

Comment on attachment 327838 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=327838&action=review LGTM on the logic, just some suggestions about naming improvements. > Tools/Scripts/download-latest-github-release.py:49 > + UP_TO_DATE_MAYBE = 3 Something like USING_EXISTING_VERSION would be clearer here. > Tools/Scripts/download-latest-github-release.py:85 > +def current_release(version_info_path): I think we should say "existing" instead. "current" sounds synonymous with "latest". > Tools/Scripts/download-latest-github-release.py:127 > + print 'Cannot download:', e Nit: You could probably align with the HTTPError case and do `print error.code, error.reason`, but this is fine too. > Tools/Scripts/download-latest-github-release.py:131 > + print 'Use current version:', version_info Nit: 'Using existing version:' would read better.

Basuke Suzuki

Comment 7 2017-11-30 14:36:06 PST

Created attachment 328031 [details] fix Thanks, Ross. I've changed them except error display. It doesn't have code property.

Basuke Suzuki

Comment 8 2017-11-30 14:37:53 PST

Created attachment 328032 [details] added reviewer Reviewed by Alex

Basuke Suzuki

Comment 9 2017-11-30 14:59:29 PST

Created attachment 328035 [details] added message output

WebKit Commit Bot

Comment 10 2017-11-30 15:39:18 PST

Comment on attachment 328035 [details] added message output Clearing flags on attachment: 328035 Committed r225361: <https://trac.webkit.org/changeset/225361>

WebKit Commit Bot

Comment 11 2017-11-30 15:39:19 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2017-11-30 15:40:33 PST

<rdar://problem/35784702>

Note You need to log in before you can comment on or make changes to this bug.