Bug 180041 – Give Document a strongly typed identifier instead of a uint64_t

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

Give Document a strongly typed identifier instead of a uint64_t, for clarity.

[Chris Dumez]

Created attachment 327648 [details]
Patch

[youenn fablet]

Comment on attachment 327648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327648&action=review

> Source/WebCore/workers/service/ServiceWorkerClientIdentifier.h:40
> +    String toString() const { return String::number(serverConnectionIdentifier.toUInt64()) + "-" +  String::number(contextIdentifier.toUInt64()); }

Use StringBuilder?

Also, is this toString() being used to generate client ids, thus potentially exposing to the web page server connection id and context id?
If so, I am wondering whether we should not use some random UUID, at least when exposing the clientId to the web page, or have the storage process generate those random IDs.

[Brady Eidson]

Comment on attachment 327648 [details]
Patch

Fine once EWS is happy

[Chris Dumez]

Comment on attachment 327648 [details]
Patch

Clearing flags on attachment: 327648

Committed r225184: <https://trac.webkit.org/changeset/225184>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35703725>