Bug 180032

Summary: [WPE][GTK] Improve contents of pkg-config .pc files
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, commit-queue, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2017-11-27 05:50:47 PST
The .pc files for the WPE and GTK+ ports could use some love: - Missing “URL” fields. - The “Name” field could be nicer, e.g. it reads just “WebKit2” for the GTK+ port, when it probably should be “WebKitGTK+”.
Attachments
Patch (2.78 KB, patch)
2017-11-27 05:54 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-11-27 05:54:09 PST
Created attachment 327631 [details] Patch
Adrian Perez
Comment 2 2017-11-27 05:56:17 PST
(In reply to Adrian Perez from comment #0) > The .pc files for the WPE and GTK+ ports could use some love: > > - Missing “URL” fields. > - The “Name” field could be nicer, e.g. it reads just “WebKit2” for > the GTK+ port, when it probably should be “WebKitGTK+”. Also, both WPE and GTK+ ports had the value “WebKit2” in their “Name” fields. It seems better to have different names ;-)
WebKit Commit Bot
Comment 3 2017-11-27 06:16:56 PST
Comment on attachment 327631 [details] Patch Clearing flags on attachment: 327631 Committed r225167: <https://trac.webkit.org/changeset/225167>
WebKit Commit Bot
Comment 4 2017-11-27 06:16:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-27 06:17:25 PST
<rdar://problem/35696892>
Note You need to log in before you can comment on or make changes to this bug.