Bug 180022

Summary: [FTL] Support DeleteById and DeleteByVal
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2017-11-26 17:08:02 PST
[FTL] Support DeleteById and DeleteByVal
Attachments
Patch (5.72 KB, patch)
2017-11-26 17:10 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (5.72 KB, patch)
2017-11-26 17:11 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-11-26 17:10:09 PST
Created attachment 327595 [details] Patch
Yusuke Suzuki
Comment 2 2017-11-26 17:11:32 PST
Created attachment 327596 [details] Patch
Saam Barati
Comment 3 2017-11-26 17:21:30 PST
Comment on attachment 327596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327596&action=review > Source/JavaScriptCore/ChangeLog:11 > + We should increase the coverage of FTL. Even if the code includes DeleteById, > + it does not mean that remaining part of the code should not be optimized in FTL. > + Right now, even CallEval and `with` scope are handled in FTL. > + Nice. I remember doing this a while ago too locally! I forgot to land it :(
Yusuke Suzuki
Comment 4 2017-11-26 17:25:46 PST
Comment on attachment 327596 [details] Patch Thanks :D
WebKit Commit Bot
Comment 5 2017-11-26 19:46:01 PST
Comment on attachment 327596 [details] Patch Clearing flags on attachment: 327596 Committed r225153: <https://trac.webkit.org/changeset/225153>
WebKit Commit Bot
Comment 6 2017-11-26 19:46:02 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-26 19:48:28 PST
<rdar://problem/35691734>
Note You need to log in before you can comment on or make changes to this bug.