Bug 180016

Summary: [JSC] Remove JSStringBuilder
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2017-11-26 08:18:33 PST
[JSC] Remove JSStringBuilder
Attachments
Patch (19.66 KB, patch)
2017-11-26 08:19 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (19.71 KB, patch)
2017-11-26 08:27 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-11-26 08:19:22 PST
Created attachment 327583 [details] Patch
EWS Watchlist
Comment 2 2017-11-26 08:21:03 PST
Attachment 327583 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/FunctionPrototype.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2017-11-26 08:27:01 PST
Created attachment 327584 [details] Patch
Saam Barati
Comment 4 2017-11-26 15:37:13 PST
Comment on attachment 327584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327584&action=review > Source/JavaScriptCore/runtime/JSStringInlines.h:50 > + String result = tryMakeString(string, strings...); Would it be better to use forwarding semantics here?
Yusuke Suzuki
Comment 5 2017-11-26 17:18:50 PST
Comment on attachment 327584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327584&action=review >> Source/JavaScriptCore/runtime/JSStringInlines.h:50 >> + String result = tryMakeString(string, strings...); > > Would it be better to use forwarding semantics here? Yeah, good call! Changed :D
Yusuke Suzuki
Comment 6 2017-11-26 17:22:49 PST
Committed r225150: <https://trac.webkit.org/changeset/225150>
Radar WebKit Bug Importer
Comment 7 2017-11-26 17:23:26 PST
<rdar://problem/35690851>
Note You need to log in before you can comment on or make changes to this bug.