Bug 180011

Summary: One too many zeroes in macOS version number in FeatureDefines
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, ews-watchlist, keith_miller, mark.lam, mitz, msaboff, saam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Tim Horton
Reported 2017-11-25 00:25:44 PST
One too many zeroes in macOS version number in FeatureDefines
Attachments
Patch (21.07 KB, patch)
2017-11-25 00:26 PST, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-11-25 00:26:22 PST
Created attachment 327573 [details] Patch
Tim Horton
Comment 2 2017-11-25 00:26:50 PST
Should be no functional impact, it's just wrong.
EWS Watchlist
Comment 3 2017-11-25 00:29:11 PST
Attachment 327573 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2017-11-27 09:59:26 PST
https://trac.webkit.org/changeset/225179/webkit
Radar WebKit Bug Importer
Comment 5 2017-11-27 10:00:31 PST
<rdar://problem/35700024>
Daniel Bates
Comment 6 2017-12-11 14:59:45 PST
(In reply to Tim Horton from comment #4) > https://trac.webkit.org/changeset/225179/webkit This change broke the WebKit build on macOS Sierra. Committed build fix in <https://trac.webkit.org/changeset/225757/>. For completeness, the build breakage was originally reported in <https://bugs.webkit.org/show_bug.cgi?id=173939#c43>.
Tim Horton
Comment 7 2017-12-11 15:35:09 PST
(In reply to Daniel Bates from comment #6) > (In reply to Tim Horton from comment #4) > > https://trac.webkit.org/changeset/225179/webkit > > This change broke the WebKit build on macOS Sierra. Committed build fix in > <https://trac.webkit.org/changeset/225757/>. For completeness, the build > breakage was originally reported in > <https://bugs.webkit.org/show_bug.cgi?id=173939#c43>. Weird, wonder why my find and replace fell down. Thank you for fixing!
Note You need to log in before you can comment on or make changes to this bug.