Summary: | WebDriver: handle user prompts shown while executing scripts | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, ews-watchlist, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 179999 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-11-23 08:20:20 PST
Created attachment 327505 [details] Patch I wrote tests for this, I'll upgrade wpt tests as soon as the patch lands. See https://github.com/w3c/web-platform-tests/pull/8413 Attachment 327505 [details] did not pass style-queue:
ERROR: Source/WebDriver/Session.h:130: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:194: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Ping Brian. Comment on attachment 327505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327505&action=review r=me! > Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:569 > + for (auto id : m_evaluateJavaScriptFunctionCallbacks.keys()) { Nit: s/id/key/g Committed r225448: <https://trac.webkit.org/changeset/225448> |