| Summary: | [CoordGraphics] Remove relay CoordinatedBuffer::Client implementations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2017-11-23 02:21:07 PST
Created attachment 327490 [details]
Patch
Comment on attachment 327490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review Yes! > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:114 > + { > + GraphicsContext& context = m_buffer->context(); > + context.save(); > + context.clip(rect); > + context.drawImage(*m_image, rect, rect); > + context.restore(); > + } Why do we need another scope? > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:92 > + } Ditto. Comment on attachment 327490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review >> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:114 >> + } > > Why do we need another scope? Just for clarity, to limit the GraphicsContext reference and operations on it to a single block. Comment on attachment 327490 [details] Patch Clearing flags on attachment: 327490 Committed r225113: <https://trac.webkit.org/changeset/225113> All reviewed patches have been landed. Closing bug. |