Bug 179970 – [CoordGraphics] Remove relay CoordinatedBuffer::Client implementations

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[CoordGraphics] Remove relay CoordinatedBuffer::Client implementations

[Zan Dobersek]

Created attachment 327490 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 327490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review

Yes!

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:114
> +    {
> +        GraphicsContext& context = m_buffer->context();
> +        context.save();
> +        context.clip(rect);
> +        context.drawImage(*m_image, rect, rect);
> +        context.restore();
> +    }

Why do we need another scope?

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:92
> +    }

Ditto.

[Zan Dobersek]

Comment on attachment 327490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review

>> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:114
>> +    }
> 
> Why do we need another scope?

Just for clarity, to limit the GraphicsContext reference and operations on it to a single block.

[Zan Dobersek]

Comment on attachment 327490 [details]
Patch

Clearing flags on attachment: 327490

Committed r225113: <https://trac.webkit.org/changeset/225113>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35674932>