Bug 179965

Summary: WebSWServerConnection should register/unregister itself with the StorageProcess
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, darin, ggaren, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-11-22 22:25:05 PST
WebSWServerConnection should register/unregister itself with the StorageProcess instead of relying on StorageToWebProcessConnection to do so on its behalf. This is less error-prone.
Attachments
Patch (3.73 KB, patch)
2017-11-22 22:26 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.85 KB, patch)
2017-11-22 22:42 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-22 22:26:12 PST
Created attachment 327482 [details] Patch
Chris Dumez
Comment 2 2017-11-22 22:42:38 PST
Created attachment 327483 [details] Patch
Darin Adler
Comment 3 2017-11-23 09:31:23 PST
Comment on attachment 327483 [details] Patch Looks good. I noticed that we delete the copy constructor but not the assignment operator from WebSWServerConnection; not sure if that’s good. I don’t absolutely love WTF_MAKE_NONCOPYABLE, but one of its benefits is that it deletes both. By the way, I just noticed that the "private:" in Noncopyable.h is no longer needed, now that we use "delete". I should remove that since it would make the macro easier to use.
WebKit Commit Bot
Comment 4 2017-11-23 09:51:50 PST
Comment on attachment 327483 [details] Patch Clearing flags on attachment: 327483 Committed r225118: <https://trac.webkit.org/changeset/225118>
WebKit Commit Bot
Comment 5 2017-11-23 09:51:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-23 09:52:25 PST
<rdar://problem/35677379>
Note You need to log in before you can comment on or make changes to this bug.