Bug 179960

Summary: [WinCairo] WebPreferences IDL not regenerating
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, Hironori.Fujii, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173352
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2017-11-22 17:15:46 PST
There were issues when landing https://bugs.webkit.org/show_bug.cgi?id=179385 which point to the generated WebPreferences getting stale. This should be resolved to allow WinCairo to build after changes to the preferences. ..\..\Source\WebKitLegacy\win\WebView.cpp(5246): error C2039: 'visualViewportAPIEnabled': is not a member of 'IWebPreferencesPrivate6' See https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/8578/steps/compile-webkit/logs/stdio
Attachments
Patch (1.53 KB, patch)
2017-11-23 18:52 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-11-22 18:05:37 PST
Looks like a similar issue with: Bug 173352 – [Win] WebKit shouldn't include the forwarding header of WebKit itself
Fujii Hironori
Comment 2 2017-11-23 18:52:21 PST
Created attachment 327518 [details] Patch
WebKit Commit Bot
Comment 3 2017-11-24 11:52:58 PST
Comment on attachment 327518 [details] Patch Clearing flags on attachment: 327518 Committed r225139: <https://trac.webkit.org/changeset/225139>
WebKit Commit Bot
Comment 4 2017-11-24 11:53:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-24 11:53:26 PST
<rdar://problem/35684422>
Note You need to log in before you can comment on or make changes to this bug.