Bug 179940

Summary:

WebDriver: add timeout option to run-webdriver-tests script

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, clopez, ews-watchlist, glenn, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	clopez: review+

Carlos Garcia Campos

Reported 2017-11-22 03:49:55 PST

We need to support timeouts to be able to run the tests in the bots.

Attachments
Patch (6.40 KB, patch) 2017-11-22 03:55 PST, Carlos Garcia Campos	clopez: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2017-11-22 03:55:31 PST

Created attachment 327449 [details] Patch

EWS Watchlist

Comment 2 2017-11-22 03:58:07 PST

Attachment 327449 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:44: No name 'pytest_timeout' in module 'webkitpy.thirdparty.autoinstalled' [pylint/E0611] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:141: [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'do_wdspec' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:141: [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member [pylint/E1101] [5] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Carlos Garcia Campos

Comment 3 2017-11-28 04:45:38 PST

Committed r225211: <https://trac.webkit.org/changeset/225211>

Radar WebKit Bug Importer

Comment 4 2017-11-28 04:46:31 PST

<rdar://problem/35720714>

Note You need to log in before you can comment on or make changes to this bug.