Bug 179923

Summary: [JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2017-11-21 08:49:29 PST
[JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
Attachments
Patch (9.58 KB, patch)
2017-11-21 08:50 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.85 KB, patch)
2017-11-21 09:06 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-11-21 08:50:54 PST
Created attachment 327413 [details] Patch
Yusuke Suzuki
Comment 2 2017-11-21 08:52:29 PST
Comment on attachment 327413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327413&action=review > Source/JavaScriptCore/runtime/HashMapImpl.h:598 > + ASSERT(!newEntry->deleted()); This ensures that added key is always non empty.
Yusuke Suzuki
Comment 3 2017-11-21 09:06:24 PST
Created attachment 327415 [details] Patch
Yusuke Suzuki
Comment 4 2017-11-24 02:44:07 PST
Comment on attachment 327415 [details] Patch Thank you!
WebKit Commit Bot
Comment 5 2017-11-24 03:04:43 PST
Comment on attachment 327415 [details] Patch Clearing flags on attachment: 327415 Committed r225130: <https://trac.webkit.org/changeset/225130>
WebKit Commit Bot
Comment 6 2017-11-24 03:04:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-24 03:05:25 PST
<rdar://problem/35682010>
Note You need to log in before you can comment on or make changes to this bug.