| Summary: | [JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2017-11-21 08:49:29 PST
Created attachment 327413 [details]
Patch
Comment on attachment 327413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327413&action=review > Source/JavaScriptCore/runtime/HashMapImpl.h:598 > + ASSERT(!newEntry->deleted()); This ensures that added key is always non empty. Created attachment 327415 [details]
Patch
Comment on attachment 327415 [details]
Patch
Thank you!
Comment on attachment 327415 [details] Patch Clearing flags on attachment: 327415 Committed r225130: <https://trac.webkit.org/changeset/225130> All reviewed patches have been landed. Closing bug. |