| Summary: | [WinCairo] Enable WebP support | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||
| Component: | Platform | Assignee: | Don Olmstead <don.olmstead> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, annulen, bfulgham, commit-queue, ews-watchlist, pvollan, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=255649 | ||||||||||
| Bug Depends on: | 170594 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Don Olmstead
2017-11-20 19:50:44 PST
Currently blocked on enabling due to WebKit using /MT instead of /MD Created attachment 327384 [details]
Patch
Comment on attachment 327384 [details]
Patch
Will only commit after the dependent bug is landed.
It might make sense to have WebP as optional dependency, as it is not really essential for Web (In reply to Konstantin Tokarev from comment #4) > It might make sense to have WebP as optional dependency, as it is not really > essential for Web Its being distributed in the updated WinCairoRequirements. Also GTK/WPE have it as REQUIRED as well. Is there a specific reason why WebP is needed? Do you have content that requires it? Created attachment 329149 [details]
Patch
Add webp but make it optional
Attachment 329149 [details] did not pass style-queue:
ERROR: Source/cmake/OptionsWinCairo.cmake:18: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 329153 [details]
Patch
Comment on attachment 329153 [details] Patch Clearing flags on attachment: 329153 Committed r225817: <https://trac.webkit.org/changeset/225817> All reviewed patches have been landed. Closing bug. |