Bug 179908

Summary: [WinCairo] Enable WebP support
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, ews-watchlist, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=255649
Bug Depends on: 170594    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Don Olmstead
Reported 2017-11-20 19:50:44 PST
WinCairoRequirements is building WebP. Now it just needs to be enabled.
Attachments
Patch (1.08 KB, patch)
2017-11-20 19:54 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (981 bytes, patch)
2017-12-12 13:41 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (982 bytes, patch)
2017-12-12 14:11 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-11-20 19:51:58 PST
Currently blocked on enabling due to WebKit using /MT instead of /MD
Don Olmstead
Comment 2 2017-11-20 19:54:38 PST
Created attachment 327384 [details] Patch
Don Olmstead
Comment 3 2017-11-20 19:55:35 PST
Comment on attachment 327384 [details] Patch Will only commit after the dependent bug is landed.
Konstantin Tokarev
Comment 4 2017-11-21 13:33:01 PST
It might make sense to have WebP as optional dependency, as it is not really essential for Web
Don Olmstead
Comment 5 2017-11-21 13:36:49 PST
(In reply to Konstantin Tokarev from comment #4) > It might make sense to have WebP as optional dependency, as it is not really > essential for Web Its being distributed in the updated WinCairoRequirements. Also GTK/WPE have it as REQUIRED as well.
Alex Christensen
Comment 6 2017-11-27 09:22:42 PST
Is there a specific reason why WebP is needed? Do you have content that requires it?
Don Olmstead
Comment 7 2017-12-12 13:41:45 PST
Created attachment 329149 [details] Patch Add webp but make it optional
EWS Watchlist
Comment 8 2017-12-12 13:43:40 PST
Attachment 329149 [details] did not pass style-queue: ERROR: Source/cmake/OptionsWinCairo.cmake:18: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 9 2017-12-12 14:11:20 PST
Created attachment 329153 [details] Patch
WebKit Commit Bot
Comment 10 2017-12-12 15:41:29 PST
Comment on attachment 329153 [details] Patch Clearing flags on attachment: 329153 Committed r225817: <https://trac.webkit.org/changeset/225817>
WebKit Commit Bot
Comment 11 2017-12-12 15:41:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-12-12 15:42:23 PST
<rdar://problem/36007096>
Note You need to log in before you can comment on or make changes to this bug.