Bug 179868

Summary: Mechanical cleanup of FE* files
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2017-11-18 16:57:23 PST
Mechanical cleanup of FE* files
Comment 1 Simon Fraser (smfr) 2017-11-18 16:59:31 PST
Created attachment 327327 [details]
Patch
Comment 2 Wenson Hsieh 2017-11-18 17:09:59 PST
Comment on attachment 327327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327327&action=review

r=mews

> Source/WebCore/platform/graphics/filters/FEColorMatrix.h:44
>      bool setType(ColorMatrixType);

This seems straightforward enough that we could just inline it alongside the getter above.

> Source/WebCore/platform/graphics/filters/FEColorMatrix.h:55
> +    void platformApplySoftware() override;

Is FEColorMatrix something we might want to subclass? If not, we should consider just making this final.

> Source/WebCore/platform/graphics/filters/FEColorMatrix.h:57
> +    WTF::TextStream& externalRepresentation(WTF::TextStream&, int indention) const override;

Ditto.
Comment 3 WebKit Commit Bot 2017-11-18 17:55:41 PST
Comment on attachment 327327 [details]
Patch

Clearing flags on attachment: 327327

Committed r225026: <https://trac.webkit.org/changeset/225026>
Comment 4 WebKit Commit Bot 2017-11-18 17:55:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-18 17:56:19 PST
<rdar://problem/35634859>