Bug 179864

Summary: filter-build-webkit filters out useful compiler error lines
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, dino, jbedard, lforschler, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2017-11-18 13:03:06 PST
filter-build-webkit turns this: In file included from /Volumes/DataSSD/Development/apple/webkit/OpenSource/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource356.cpp:1: /Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing] std::max(0, std::min(static_cast<int>(floatComponents.components[0] * 255), 255)), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: note: insert an explicit cast to silence this issue std::max(0, std::min(static_cast<int>(floatComponents.components[0] * 255), 255)), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ static_cast<float>( ) into this: In file included from /Volumes/DataSSD/Development/apple/webkit/OpenSource/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource356.cpp:1: /Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: note: insert an explicit cast to silence this issue ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ static_cast<float>( ) which hides some detail needed to fix bugs.
Attachments
Patch (1.12 KB, patch)
2017-12-20 14:52 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (1.96 KB, patch)
2018-01-03 11:48 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-12-20 14:52:06 PST
Created attachment 329955 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-01-03 11:48:55 PST
Created attachment 330405 [details] Patch
WebKit Commit Bot
Comment 3 2018-01-03 16:42:24 PST
Comment on attachment 330405 [details] Patch Clearing flags on attachment: 330405 Committed r226378: <https://trac.webkit.org/changeset/226378>
WebKit Commit Bot
Comment 4 2018-01-03 16:42:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-03 16:43:24 PST
<rdar://problem/36287675>
Note You need to log in before you can comment on or make changes to this bug.