Bug 179859

Summary: [WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2017-11-18 05:36:45 PST
[WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
Attachments
Patch (5.57 KB, patch)
2017-11-18 05:39 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (5.93 KB, patch)
2017-11-18 06:02 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (5.93 KB, patch)
2017-11-18 06:05 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-11-18 05:39:59 PST
Created attachment 327309 [details] Patch
JF Bastien
Comment 2 2017-11-18 05:50:27 PST
Comment on attachment 327309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327309&action=review > Source/WTF/wtf/StackBounds.cpp:61 > + result = testStackDirection(nullptr); I don’t think nullptr is valid here. > Source/WTF/wtf/StackBounds.cpp:65 > + Seems like we can hardcode direction for known cpus here so they constant food away.
Yusuke Suzuki
Comment 3 2017-11-18 05:52:47 PST
Comment on attachment 327309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327309&action=review >> Source/WTF/wtf/StackBounds.cpp:61 >> + result = testStackDirection(nullptr); > > I don’t think nullptr is valid here. I'll split this function to offer stack pointer to this function. >> Source/WTF/wtf/StackBounds.cpp:65 >> + > > Seems like we can hardcode direction for known cpus here so they constant food away. I'll do this for major CPUs.
Yusuke Suzuki
Comment 4 2017-11-18 06:02:55 PST
Created attachment 327310 [details] Patch
JF Bastien
Comment 5 2017-11-18 06:05:31 PST
Comment on attachment 327310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327310&action=review r=me with bugfix > Source/WTF/wtf/StackBounds.cpp:72 > + result = testStackDirection(nullptr); That won’t compile with nullptr :)
Yusuke Suzuki
Comment 6 2017-11-18 06:05:52 PST
Created attachment 327311 [details] Patch
Yusuke Suzuki
Comment 7 2017-11-18 06:06:37 PST
Comment on attachment 327310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327310&action=review >> Source/WTF/wtf/StackBounds.cpp:72 >> + result = testStackDirection(nullptr); > > That won’t compile with nullptr :) Oops. Thanks. Fixed.
Yusuke Suzuki
Comment 8 2017-11-18 06:10:05 PST
Committed r225015: <https://trac.webkit.org/changeset/225015>
Radar WebKit Bug Importer
Comment 9 2017-11-18 06:11:34 PST
<rdar://problem/35631948>
Note You need to log in before you can comment on or make changes to this bug.