Summary: | [WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2017-11-18 05:36:45 PST
Created attachment 327309 [details]
Patch
Comment on attachment 327309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327309&action=review > Source/WTF/wtf/StackBounds.cpp:61 > + result = testStackDirection(nullptr); I don’t think nullptr is valid here. > Source/WTF/wtf/StackBounds.cpp:65 > + Seems like we can hardcode direction for known cpus here so they constant food away. Comment on attachment 327309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327309&action=review >> Source/WTF/wtf/StackBounds.cpp:61 >> + result = testStackDirection(nullptr); > > I don’t think nullptr is valid here. I'll split this function to offer stack pointer to this function. >> Source/WTF/wtf/StackBounds.cpp:65 >> + > > Seems like we can hardcode direction for known cpus here so they constant food away. I'll do this for major CPUs. Created attachment 327310 [details]
Patch
Comment on attachment 327310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327310&action=review r=me with bugfix > Source/WTF/wtf/StackBounds.cpp:72 > + result = testStackDirection(nullptr); That won’t compile with nullptr :) Created attachment 327311 [details]
Patch
Comment on attachment 327310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327310&action=review >> Source/WTF/wtf/StackBounds.cpp:72 >> + result = testStackDirection(nullptr); > > That won’t compile with nullptr :) Oops. Thanks. Fixed. Committed r225015: <https://trac.webkit.org/changeset/225015> |